HeartSaVioR commented on a change in pull request #25943:
[WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for
(SQL)AppStatusListener
URL: https://github.com/apache/spark/pull/25943#discussion_r335715084
##########
File path: core/src/main/scala/org/apache/spark/status/storeTypes.scala
##########
@@ -76,6 +109,29 @@ private[spark] class JobDataWrapper(
@JsonIgnore @KVIndex("completionTime")
private def completionTime: Long =
info.completionTime.map(_.getTime).getOrElse(-1L)
+
+ def toLiveJob: LiveJob = {
Review comment:
I'm not sure we are OK with lossy information - we shouldn't let developer
access information to do something which can be lost after restoring, but how?
Leaving comments? Whenever we modify AppStatusListener to add some feature, we
may have to struggle with both things - compatibility with old snapshot of
state, and uncertain of lossy information if we cannot control well.
Ideally we would have to restore state of listener as same as it was; if we
have to snapshot the state of listener in driver, memory consumption and
performance would really matter as it affects live application. For SHS, we
will have less pressure on this, and actually memory consumption would less
matter as in fact we are not tied to store the state of listener in "KVStore".
It could be another file along with snapshot file on KVStore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
