LinhongLiu commented on issue #26134: [SPARK-29486][SQL] CalendarInterval should have 3 fields: months, days and microseconds URL: https://github.com/apache/spark/pull/26134#issuecomment-542964989 @MaxGekk I think both of us agreed now that undetermined zone offset can cause ambiguity if user want add a 'interval 1 day' and different user may want different time shift ( 24 hours or 25 hours) My PR change current behavior but it gives the user a choice to use a physical 1 day (23,24,25 hours maybe) or use a logical 1 day (24 hours exactly, this is consistent to current behavior). This change can reduce the ambiguity. At last, about the 30% memory consume, in my opinion, CalendarInterval usually is a constant value and used to shift a column of timestamp type. This means we rarely save CalendarInterval as a column of a table. So memory consuming is not really a big problem.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
