vanzin commented on a change in pull request #25910: [SPARK-28762][CORE] Read
JAR main class if JAR is not located in local file system
URL: https://github.com/apache/spark/pull/25910#discussion_r336089791
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -437,6 +438,37 @@ private[spark] class SparkSubmit extends Logging {
}.orNull
}
+ def resolveMainClassIfNeeded(jarPath: String): Try[String] = {
Review comment:
I think this looks better inlined below in the only place where it's called;
also using a normal `try...catch` instead of a `Try` + match.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
