srowen commented on a change in pull request #26132: [SPARK-29387][SQL] Support
`*` and `/` operators for intervals
URL: https://github.com/apache/spark/pull/26132#discussion_r336207474
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
##########
@@ -355,6 +355,22 @@ public CalendarInterval subtract(CalendarInterval that) {
return new CalendarInterval(months, microseconds);
}
+ private static CalendarInterval fromDoubles(double months, double
microseconds) {
+ long roundedMonths = (long)(months);
+ // Using 30 days per month as PostgreSQL does.
Review comment:
Sounds good.
General question: why are we using PostgreSQL as the point of reference? I'm
not objecting to it, just never saw what the motivation was for adding all of
the PostgreSQL functionality down to small items like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
