MaxGekk commented on a change in pull request #26132: [SPARK-29387][SQL]
Support `*` and `/` operators for intervals
URL: https://github.com/apache/spark/pull/26132#discussion_r336216233
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
##########
@@ -355,6 +355,22 @@ public CalendarInterval subtract(CalendarInterval that) {
return new CalendarInterval(months, microseconds);
}
+ private static CalendarInterval fromDoubles(double months, double
microseconds) {
+ long roundedMonths = (long)(months);
+ // Using 30 days per month as PostgreSQL does.
Review comment:
Here is operations defined by the SQL standard:
<img width="727" alt="Screen Shot 2019-10-17 at 23 38 37"
src="https://user-images.githubusercontent.com/1580697/67045609-54d12a00-f137-11e9-8fdd-c2e9f733f456.png";>
By having `*` and `/` for intervals, we cover all interval operations
defined by the SQL standard which is not bad, isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/1580697/67045609-54d12a00-f137-11e9-8fdd-c2e9f733f456.png"](https://user-images.githubusercontent.com/1580697/67045609-54d12a00-f137-11e9-8fdd-c2e9f733f456.png"){kind=link}