huaxingao commented on issue #26154: [SPARK-29232][ML] Update the parameter maps of the DecisionTreeRegression/Classification Models URL: https://github.com/apache/spark/pull/26154#issuecomment-543485841 > copyValues suppose that > Warning: This implicitly assumes that this [[Params]] instance and the target instance share the same set of default Params. > > Is this satisfied? The trees in ```RandomForestRegressionModel``` is an Array of ```DecisionTreeRegressionModel```. ```DecisionTreeRegressionModel``` doesn't have exact the same params as ```RandomForestRegressor```, but for the params they share, it seems to me that the underlying ```trees``` and ```RandomForestRegressor``` should have the same values.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
