cloud-fan commented on a change in pull request #26157: [SPARK-28560][SQL][followup] resolve the remaining comments for PR#25295 URL: https://github.com/apache/spark/pull/26157#discussion_r336342585
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ########## @@ -229,6 +229,8 @@ class AdaptiveQueryExecSuite assert(smj.size == 3) val bhj = findTopLevelBroadcastHashJoin(adaptivePlan) assert(bhj.size == 2) + checkNumLocalShuffleReaders(adaptivePlan, 1) Review comment: there are 2 broadcast joins, but we only have 1 local shuffle reader. Why is it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org