juliuszsompolski commented on a change in pull request #25868:
[SPARK-28527][SQL][TEST] Enable ThriftServerQueryTestSuite
URL: https://github.com/apache/spark/pull/25868#discussion_r336551407
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -43,12 +45,12 @@ import org.apache.spark.sql.types._
* 2. Support DESC command.
* 3. Support SHOW command.
*/
-@Ignore
class ThriftServerQueryTestSuite extends SQLQueryTestSuite {
private var hiveServer2: HiveThriftServer2 = _
- override def beforeEach(): Unit = {
+ override def beforeAll(): Unit = {
+ super.beforeAll()
Review comment:
In an earlier PR I commented that the flakiness may be because of async
issues.
I meant that calling `startThriftServer` actually starts some things
asynchronously in the background before the server becomes ready.
Moving it to `beforeAll` instead of `beforeEach` should help the flakiness
by having this race only at the start of the suite and not before every test,
but I think adding a 3 or 5 s sleep would make sure it never happens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
