Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3670#discussion_r23972230
  
    --- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
    @@ -72,4 +74,87 @@ class SparkContextSuite extends FunSuite with 
LocalSparkContext {
         val byteArray2 = converter.convert(bytesWritable)
         assert(byteArray2.length === 0)
       }
    +
    +  test("addFile works") {
    +    val file = new File("somefile")
    +    val absolutePath = file.getAbsolutePath
    +    try {
    +      val pw = new PrintWriter(file)
    +      pw.print("somewords")
    +      pw.close()
    +      val length = file.length()
    +      sc = new SparkContext(new 
SparkConf().setAppName("test").setMaster("local"))
    +      sc.addFile(file.getAbsolutePath)
    +      sc.parallelize(Array(1), 1).map(x => {
    +        val gotten = new File(SparkFiles.get(file.getName))
    --- End diff --
    
    AFAIK you can serialize `File` instances:
    
    ```scala
    scala> import java.io.File
    import java.io.File
    
    scala> import org.apache.commons.lang3.SerializationUtils
    import org.apache.commons.lang3.SerializationUtils
    
    scala> SerializationUtils.serialize(new File("/usr/share/dict/words"))
    res1: Array[Byte] = Array(-84, -19, 0, 5, 115, 114, 0, 12, 106, 97, 118, 
97, 46, 105, 111, 46, 70, 105, 108, 101, 4, 45, -92, 69, 14, 13, -28, -1, 3, 0, 
1, 76, 0, 4, 112, 97, 116, 104, 116, 0, 18, 76, 106, 97, 118, 97, 47, 108, 97, 
110, 103, 47, 83, 116, 114, 105, 110, 103, 59, 120, 112, 116, 0, 21, 47, 117, 
115, 114, 47, 115, 104, 97, 114, 101, 47, 100, 105, 99, 116, 47, 119, 111, 114, 
100, 115, 119, 2, 0, 47, 120)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to