viirya commented on a change in pull request #26164: [SPARK-21492][SQL] Fix
memory leak in SortMergeJoin
URL: https://github.com/apache/spark/pull/26164#discussion_r336669042
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SortExec.scala
##########
@@ -87,13 +95,13 @@ case class SortExec(
}
val pageSize = SparkEnv.get.memoryManager.pageSizeBytes
- val sorter = UnsafeExternalRowSorter.create(
+ rowSorter = UnsafeExternalRowSorter.create(
Review comment:
Although createSorter should be called just once, it is better to check if
rowSorter was already set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
