rdblue commented on a change in pull request #25024: [SPARK-27296][SQL] User 
Defined Aggregators that do not ser/de on each input row
URL: https://github.com/apache/spark/pull/25024#discussion_r336707125
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/SQLContextSuite.scala
 ##########
 @@ -51,7 +51,7 @@ class SQLContextSuite extends SparkFunSuite with 
SharedSparkContext {
 
     // UDF should not be shared
     def myadd(a: Int, b: Int): Int = a + b
-    session1.udf.register[Int, Int, Int]("myadd", myadd)
+    session1.udf.register[Int, Int, Int]("myadd", myadd(_, _))
 
 Review comment:
   Not sure I follow why it is confusing Scala. Why would adding a new method 
that accepts Aggregator cause another overload to stop working? Aggregator 
isn't a Function2

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to