kangtiann commented on issue #26149: [SPARK-29267][CORE] Support 
rdd.countApprox should stop when 'timeout'
URL: https://github.com/apache/spark/pull/26149#issuecomment-544331897
 
 
   > > Current countApprox(timeout: Long, confidence: Double = 0.95) can not 
stop when timeout comes, still running at background, this is a waste of 
resources.
   > 
   > This should be a bug, and a bug-fix is expected.
   
   `org.apache.spark.partial.PartialResult` is return by countApprox(), 
PartialResult.getFinalValue() allow us to get final value if wait more time.
   
   I think get `final value` is confused, if job is stoped when timeout, how 
get `final value`  ?
   
   If job should stop when timeout , we must remove `getFinalValue()` from 
PartialResult.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to