uncleGen commented on a change in pull request #26162: [SPARK-29438][SS] Use 
partition ID of StateStoreAwareZipPartitionsRDD for determining partition ID of 
state store in stream-stream join
URL: https://github.com/apache/spark/pull/26162#discussion_r336850996
 
 

 ##########
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
 ##########
 @@ -712,5 +709,32 @@ class StreamingOuterJoinSuite extends StreamTest with 
StateStoreMetricsTest with
       assertNumStateRows(total = 2, updated = 2)
     )
   }
-}
 
+  test("SPARK-29438: ensure UNION doesn't lead stream-stream join to use 
shifted partition IDs") {
+    withSQLConf(AUTO_BROADCASTJOIN_THRESHOLD.key -> "1") {
 
 Review comment:
   Would we be better to add some comment here to explain why set 
AUTO_BROADCASTJOIN_THRESHOLD with "1", otherwise it maybe a little weird.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to