viirya commented on a change in pull request #26173: [SPARK-29503][SQL] Copy 
result row from RowWriter in GenerateUnsafeProjection when the expression is 
lambdaFunction in MapObject
URL: https://github.com/apache/spark/pull/26173#discussion_r336879389
 
 

 ##########
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameComplexTypeSuite.scala
 ##########
 @@ -64,6 +70,33 @@ class DataFrameComplexTypeSuite extends QueryTest with 
SharedSparkSession {
     val ds100_5 = Seq(S100_5()).toDS()
     ds100_5.rdd.count
   }
+
+  test("SPARK-29503 nest unsafe struct inside safe array") {
+    withSQLConf(SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key -> "false") {
 
 Review comment:
   I see. For whole stage codegen, CreateNamedStruct is not converted to 
CreateNamedStructUnsafe, so the nested struct is not unsafe one. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to