HyukjinKwon commented on a change in pull request #26175:
[SPARK-29518][SQL][TEST] Benchmark `date_part` for `INTERVAL`
URL: https://github.com/apache/spark/pull/26175#discussion_r336937284
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/ExtractBenchmark.scala
##########
@@ -84,24 +86,36 @@ object ExtractBenchmark extends SqlBasedBenchmark {
}
}
+ private case class Settings(fields: Seq[String], func: Seq[String], iterNum:
Long)
+
override def runBenchmarkSuite(mainArgs: Array[String]): Unit = {
val N = 10000000L
- val fields = Seq(
+ val datetimeFields = Seq(
"MILLENNIUM", "CENTURY", "DECADE", "YEAR",
"ISOYEAR", "QUARTER", "MONTH", "WEEK",
"DAY", "DAYOFWEEK", "DOW", "ISODOW",
"DOY", "HOUR", "MINUTE", "SECOND",
"MILLISECONDS", "MICROSECONDS", "EPOCH")
+ val intervalFields = Seq(
+ "MILLENNIUM", "CENTURY", "DECADE", "YEAR",
+ "QUARTER", "MONTH", "DAY",
+ "HOUR", "MINUTE", "SECOND",
+ "MILLISECONDS", "MICROSECONDS", "EPOCH")
+ val settings = Map(
Review comment:
not a big deal but `Settings` seems only used within `runBenchmarkSuite`. I
think it's fine to just make this pretty with indentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
