rdblue commented on a change in pull request #25955: [SPARK-29277][SQL] Add
early DSv2 filter and projection pushdown
URL: https://github.com/apache/spark/pull/25955#discussion_r337127812
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -324,6 +330,8 @@ class ResolveSessionCatalog(
object SessionCatalog {
def unapply(nameParts: Seq[String]): Option[(CatalogPlugin, Seq[String])]
= nameParts match {
+ case AsTemporaryViewIdentifier(i) if
catalogManager.v1SessionCatalog.isTemporaryTable(i) =>
Review comment:
Yes, this is needed. Without this check, commands with temporary views will
be converted to v2 plans because the v2 session catalog doesn't return a
`V1Table`. Queries like `ALTER TABLE` with a known view should not be converted
to v2 plans, or else we need more cases in `CheckAnalysis`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
