juliuszsompolski commented on a change in pull request #26172: 
[WIP][SPARK-29516][SQL][TEST] Test ThriftServerQueryTestSuite asynchronously
URL: https://github.com/apache/spark/pull/26172#discussion_r337186349
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
 ##########
 @@ -600,6 +600,7 @@ class SparkSession private(
    * @since 2.0.0
    */
   def sql(sqlText: String): DataFrame = {
+    SparkSession.setActiveSession(this)
 
 Review comment:
   So the issue with async queries was that the parser was using the wrong 
dialect fallback, because it was picking the wrong SQLConf, because it was not 
set in the background execution thread?
   @wangyum @AngersZhuuuu Does fixing this potentially fix any other of the 
failures in ThriftServerQueryTestSuite that are currently blacklisted to be 
ignored?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to