cloud-fan commented on a change in pull request #26207: [SPARK-29552][SQL] fix
the flaky test in multi-joins with local shuffle reader
URL: https://github.com/apache/spark/pull/26207#discussion_r337479584
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -92,6 +92,9 @@ case class AdaptiveSparkPlanExec(
// optimizations should be stage-independent.
@transient private val queryStageOptimizerRules: Seq[Rule[SparkPlan]] = Seq(
ReuseAdaptiveSubquery(conf, subqueryCache),
+ // Here we need put the OptimizeLocalShuffleReader rule before
+ // ReduceNumShufflePartitions rule to avoid the further optimizaiton.
Review comment:
I think the comment needs to explain 2 things:
1. why execute this rule twice
2. why it must be run before `OptimizeLocalShuffleReader`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
