HyukjinKwon commented on a change in pull request #24898: [SPARK-22340][PYTHON]
Add a mode to pin Python thread into JVM's
URL: https://github.com/apache/spark/pull/24898#discussion_r337512118
##########
File path: python/pyspark/ml/tests/test_wrapper.py
##########
@@ -28,6 +29,11 @@
class JavaWrapperMemoryTests(SparkSessionTestCase):
+ @unittest.skipIf(
+ os.environ.get("PYSPARK_PIN_THREAD", "false").lower() == "true",
+ "When the thread is pinned between Python and JVM, detaching seems not
"
+ "working. This is potentially a bug in Py4J and SPARK-18630 can be
persistent when "
+ "PYSPARK_PIN_THREAD is enabled, skipping for now.")
Review comment:
@squito, sorry for my late update. It seems passing when I added some
sleeps. Seems it just needed some delays to avoid flakiness. I fixed the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
