tgravescs commented on a change in pull request #26078: [SPARK-29151][CORE]
Support fractional resources for task resource scheduling
URL: https://github.com/apache/spark/pull/26078#discussion_r337546377
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/ExecutorResourceInfoSuite.scala
##########
@@ -80,12 +80,29 @@ class ExecutorResourceInfoSuite extends SparkFunSuite {
test("Don't allow release address that doesn't exist") {
// Init Executor Resource.
- val info = new ExecutorResourceInfo(GPU, ArrayBuffer("0", "1", "2", "3"))
+ val info = new ExecutorResourceInfo(GPU, ArrayBuffer("0", "1", "2", "3"),
1)
assert(!info.assignedAddrs.contains("4"))
// Release an address that doesn't exist
val e = intercept[SparkException] {
info.release(Array("4"))
}
assert(e.getMessage.contains("Try to release an address that doesn't
exist."))
}
+
+ test("Ensure that we can acquire the same fractions of a resource from an
executor") {
+ val slotSeq = Seq(10, 9, 8, 7, 6, 5, 4, 3, 2, 1)
+ val addresses = ArrayBuffer("0", "1", "2", "3")
+ slotSeq.foreach { slots =>
+ val info = new ExecutorResourceInfo(GPU, addresses, slots)
+ for (_ <- 0 until slots) {
+ addresses.foreach(addr => info.acquire(Seq(addr)))
+ }
+ addresses.foreach { addr =>
+ assertThrows[SparkException] {
+ info.acquire(Seq(addr))
+ }
+ assert(!info.availableAddrs.contains(addr))
Review comment:
might be nie to have assert for assignedAddrs where it returns more then 1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
