cloud-fan commented on a change in pull request #26166: [SPARK-29511][SQL]
DataSourceV2: Support CREATE NAMESPACE
URL: https://github.com/apache/spark/pull/26166#discussion_r337583743
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -83,10 +83,10 @@ statement
: query
#statementDefault
| ctes? dmlStatementNoWith
#dmlStatement
| USE NAMESPACE? multipartIdentifier #use
- | CREATE database (IF NOT EXISTS)? db=errorCapturingIdentifier
+ | CREATE (database | NAMESPACE) (IF NOT EXISTS)? multipartIdentifier
((COMMENT comment=STRING) |
locationSpec |
- (WITH DBPROPERTIES tablePropertyList))*
#createDatabase
+ (WITH DBPROPERTIES tablePropertyList))*
#createNamespace
Review comment:
Ah I missed this. Shall we use `PROPERTIES` instead of `DBPROPERTIES`? We
can write `DBPROPERTIES | PROPERTIES` for backward compatibility
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
