JkSelf commented on a change in pull request #26207: [SPARK-29552][SQL] fix the
flaky test in multi-joins with local shuffle reader
URL: https://github.com/apache/spark/pull/26207#discussion_r337819126
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -164,7 +164,7 @@ class AdaptiveQueryExecSuite
val bhj = findTopLevelBroadcastHashJoin(adaptivePlan)
assert(bhj.size == 3)
// additional shuffle exchange introduced, only one shuffle reader to
local shuffle reader.
- checkNumLocalShuffleReaders(adaptivePlan, 1)
+ checkNumLocalShuffleReaders(adaptivePlan, 2)
Review comment:
@HeartSaVioR With this patch, the value will consistently be 2. Because we
already optimize all the possible local shuffle reader. And I have run in
local dev and also the test suite, the value are all 2. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
