cloud-fan commented on a change in pull request #26205: [SPARK-29545][SQL] Add support for bit_xor aggregate function URL: https://github.com/apache/spark/pull/26205#discussion_r337844297
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/bitwiseAggregates.scala ########## @@ -97,3 +97,42 @@ case class BitOrAgg(child: Expression) extends DeclarativeAggregate with Expects override lazy val evaluateExpression: AttributeReference = bitOr } + +@ExpressionDescription( Review comment: @srowen we can treat `Expression` as a DSL, then this function is implemented by the DSL. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
