dongjoon-hyun commented on a change in pull request #26190: [SPARK-29532][SQL]
simplify interval string parsing
URL: https://github.com/apache/spark/pull/26190#discussion_r337880333
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParserInterface.scala
##########
@@ -70,4 +71,10 @@ trait ParserInterface {
*/
@throws[ParseException]("Text cannot be parsed to a DataType")
def parseDataType(sqlText: String): DataType
+
+ /**
+ * Parse a string to a [[CalendarInterval]].
+ */
+ @throws[ParseException]("Text cannot be parsed to an interval")
+ def parseInterval(sqlText: String): CalendarInterval
Review comment:
@cloud-fan . This looks like a breaking change to the existing `Parser`
`Spark Extension`. If then, this need a new JIRA. Can we have this change in a
separate JIRA PR because this is an open developer API?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
