Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4324#issuecomment-72601740
LGTM; this is a pretty straightforward change. Compared to implementing
this in Java, this gains the benefit of having this class's docs appear in
Scaladoc. I guess there's a potential downside of Java compatibility /
usability being broken should we add new methods, but I think we can address
that via our review processes. It might be nice to add a comment at the top of
the `TaskContext` and `TaskContextImpl` files referencing the
`JavaTaskCompletionListenerImpl` test case so that people remember to update it
when adding new methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
