cloud-fan commented on a change in pull request #26190: [SPARK-29532][SQL]
simplify interval string parsing
URL: https://github.com/apache/spark/pull/26190#discussion_r337967969
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/IntervalBenchmark.scala
##########
@@ -88,8 +78,6 @@ object IntervalBenchmark extends SqlBasedBenchmark {
val intervalToTest = ListBuffer[String]()
val benchmark = new Benchmark("cast strings to intervals", N, output =
output)
- addCase(benchmark, N, "string w/ interval", buildString(true, timeUnits))
- addCase(benchmark, N, "string w/o interval", buildString(false, timeUnits))
Review comment:
I believe this was a mistake. The first 2 cases do not cast string to
interval and are very fast.
Since the first 2 cases simply test all units, it's already covered below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
