HyukjinKwon commented on a change in pull request #26114: [SPARK-29468][SQL]
Change Literal.sql to be correct for floats.
URL: https://github.com/apache/spark/pull/26114#discussion_r337985181
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -370,7 +390,7 @@ case class Literal (value: Any, dataType: DataType)
extends LeafExpression {
case _ if v.isNaN => "'NaN'"
case Float.PositiveInfinity => "'Infinity'"
case Float.NegativeInfinity => "'-Infinity'"
- case _ => v
+ case _ => s"'$v'"
Review comment:
No big deal but it could be just `val castedValue = s"'$v'"`
```
scala> s"'${Double.NaN}'"
res0: String = 'NaN'
scala> s"'${Float.NegativeInfinity}'"
res1: String = '-Infinity'
scala> s"'${Float.PositiveInfinity}'"
res2: String = 'Infinity'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
