shahidki31 commented on a change in pull request #26216: [SPARK-29453][WEBUI]
Improve tooltips information for SQL tab.
URL: https://github.com/apache/spark/pull/26216#discussion_r337995897
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala
##########
@@ -73,10 +74,36 @@ class AllExecutionsPageSuite extends SharedSparkSession
with BeforeAndAfter {
map.put("failed.sort", Array("duration"))
when(request.getParameterMap()).thenReturn(map)
val html = renderSQLPage(request, tab,
statusStore).toString().toLowerCase(Locale.ROOT)
- assert(!html.contains("IllegalArgumentException"))
+ assert(!html.contains("illegalargumentexception"))
assert(html.contains("duration"))
}
+ test("Display tooltips for SQL page") {
+ val statusStore = createStatusStore
+ val tab = mock(classOf[SQLTab], RETURNS_SMART_NULLS)
+ val request = mock(classOf[HttpServletRequest])
+
+ when(tab.sqlStore).thenReturn(statusStore)
+ when(tab.appName).thenReturn("testing")
+ when(tab.headerTabs).thenReturn(Seq.empty)
+ when(request.getParameter("failed.sort")).thenReturn("Duration")
+ val map = new util.HashMap[String, Array[String]]()
+ map.put("failed.sort", Array("duration"))
Review comment:
I think these lines aren't necessary.
```
when(request.getParameter("failed.sort")).thenReturn("Duration")
val map = new util.HashMap[String, Array[String]]()
map.put("failed.sort", Array("duration"))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
