zhengruifeng commented on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#issuecomment-545402172 I manually tested this PR in repl in the past days, with some datasets in `/data/mllib`, set relative params to in normal ranges (for example `weight` in [1.0, 10.0], not extreme values (0.01, 1000) in the testsuits), and the results looked fine. I think the error is accumulated among `DecisionTree`s, so I need to loose the tolerance in test suites (compared with `DecisionTreeSuites`). I will merge this PR this week if no more comments.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
