srowen commented on a change in pull request #26212: [SPARK-29557][BUILD] Update dropwizard/codahale metrics library to 4.1.1 URL: https://github.com/apache/spark/pull/26212#discussion_r338088775
########## File path: dev/deps/spark-deps-hadoop-2.7 ########## @@ -149,10 +149,11 @@ lz4-java-1.6.0.jar machinist_2.12-0.6.8.jar macro-compat_2.12-1.1.1.jar mesos-1.4.0-shaded-protobuf.jar -metrics-core-3.1.5.jar -metrics-graphite-3.1.5.jar -metrics-json-3.1.5.jar -metrics-jvm-3.1.5.jar +metrics-core-4.1.1.jar +metrics-graphite-4.1.1.jar +metrics-jmx-4.1.1.jar Review comment: Tiny nit, could you add an entry to `LICENSE-binary` with this new dependency? you'll see where it goes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
