srowen commented on a change in pull request #26230: [SPARK-21287][SQL] Move
the validation of fetch size from JDBCOptions to JdbcDialect
URL: https://github.com/apache/spark/pull/26230#discussion_r338126461
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -150,6 +151,29 @@ abstract class JdbcDialect extends Serializable {
def beforeFetch(connection: Connection, properties: Map[String, String]):
Unit = {
}
+ /**
+ * Do some extra properties validation work in addition to the validation in
[[JDBCOptions]],
+ * eg. [[validateFetchSize()]].
+ * @param properties The connection properties. This is passed through from
the relation.
+ */
+ def validateProperties(properties: Map[String, String]): Unit = {
+ validateFetchSize(properties)
+ }
+ /**
+ * This is to validate the fetch size specified via
[[JDBCOptions.JDBC_BATCH_FETCH_SIZE]].
+ * The implementation here requires the fetch size >= 0, sub classes may
override it to meet
+ * requirement of different dialects.
+ * @param properties The connection properties. This is passed through from
the relation.
+ */
+ protected def validateFetchSize(properties: Map[String, String]): Unit = {
Review comment:
Why not just pass the fetch size as the parameter to this method? avoids
having to duplicate the logic that gets the value
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
