brkyvz commented on a change in pull request #26214: [SPARK-29558][SQL]
ResolveTables and ResolveRelations should be order-insensitive
URL: https://github.com/apache/spark/pull/26214#discussion_r338193572
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -720,13 +712,9 @@ class Analyzer(
// Note this is compatible with the views defined by older versions of
Spark(before 2.2), which
// have empty defaultDatabase and all the relations in viewText have
database part defined.
def resolveRelation(plan: LogicalPlan): LogicalPlan = plan match {
- case u @ UnresolvedRelation(AsTemporaryViewIdentifier(ident))
Review comment:
Wouldn't it be simpler to just call `ResolveTables.apply(plan) match {` here
than to embed all the logic within `lookupTableFromCatalog`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
