holdenk commented on a change in pull request #26197: Implement p-value
simulation and unit tests for chi2 test
URL: https://github.com/apache/spark/pull/26197#discussion_r338180477
##########
File path:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/ChiSqTest.scala
##########
@@ -151,6 +155,8 @@ private[spark] object ChiSqTest extends Logging {
*/
def chiSquared(observed: Vector,
expected: Vector = Vectors.dense(Array.empty[Double]),
+ simulatePValue: Boolean = false,
Review comment:
Spark MLLib is in maintaince mode, see
https://spark.apache.org/docs/latest/ml-guide.html . If we do want this I think
we need to make sure it is exposed in Spark ML.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
