srowen commented on a change in pull request #26236: [SPARK-29578][TESTS] Add 
"8634" as another skipped day for Kwajalein timzeone due to more recent 
timezone updates in later JDK 8
URL: https://github.com/apache/spark/pull/26236#discussion_r338326622
 
 

 ##########
 File path: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
 ##########
 @@ -555,12 +555,12 @@ class DateTimeUtilsSuite extends SparkFunSuite with 
Matchers {
 
     // There are some days are skipped entirely in some timezone, skip them 
here.
     val skipped_days = Map[String, Set[Int]](
-      "Kwajalein" -> Set(8632, 8633),
+      "Kwajalein" -> Set(8632, 8633, 8634),
 
 Review comment:
   I updated the JDK version. I'll ask the reporter to comment here with more 
details. That said, I think this is an obvious fix so I'm not too worried about 
those details. It doesn't happen on 1.8.0_222 at least.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to