HeartSaVioR commented on a change in pull request #25797: [SPARK-29043][Core]
Improve the concurrent performance of History Server
URL: https://github.com/apache/spark/pull/25797#discussion_r338331200
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -561,7 +555,7 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
.last(newLastScanTime - 1)
.asScala
.toList
- stale.foreach { log =>
+ stale.filterNot(isProcessing(_)).foreach { log =>
Review comment:
@turboFei
Sorry I got lost on this and revisit this now.
I agree it could be complicated, as it's really just a cleaner. For
workaround, we can just do two iterations in a single call, on first iteration
try to do all, on second iteration try only with skipped logs.
@vanzin Would the workaround work for you? Or would we have to reschedule
the interval?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
