imback82 commented on a change in pull request #26179: [SPARK-29522][SQL] CACHE
TABLE should look up catalog/table like v2 commands
URL: https://github.com/apache/spark/pull/26179#discussion_r338344164
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2769,6 +2769,29 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
RepairTableStatement(visitMultipartIdentifier(ctx.multipartIdentifier()))
}
+ /**
+<<<<<<< HEAD
+ * Create a [[CacheTableStatement]].
+ *
+ * For example:
+ * {{{
+ * CACHE [LAZY] TABLE multi_part_name
+ * [OPTIONS tablePropertyList] [[AS] query]
+ * }}}
+ */
+ override def visitCacheTable(ctx: CacheTableContext): LogicalPlan =
withOrigin(ctx) {
+ val query = Option(ctx.query).map(plan)
+ val tableName = visitMultipartIdentifier(ctx.multipartIdentifier)
+ if (query.isDefined && tableName.length > 1) {
+ val catalogAndDatabase = tableName.init.mkString(".")
Review comment:
use `MultipartIdentifierHelper.quoted`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
