cloud-fan commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545756654 The last argument is about performance: https://github.com/apache/spark/pull/26190#discussion_r338206250 My point is that: The regex-based java version is faster but it's not as functional as the antlr parser as I pointed out in the above comment. Now we are in the early stage of exposing the interval type, and we should focus more on the functionality instead of performance. For the `INTERVAL '...'` literal syntax and parsing watermark string, the performance doesn't really matter. For cast, the performance matters, but it's better to have a UTF8String based parser instead of regex-based.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
