maropu commented on a change in pull request #26230: [SPARK-21287][SQL] Move
the validation of fetch size from JDBCOptions to JdbcDialect
URL: https://github.com/apache/spark/pull/26230#discussion_r338390391
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
##########
@@ -184,6 +184,9 @@ private[jdbc] class JDBCRDD(
options: JDBCOptions)
extends RDD[InternalRow](sc, Nil) {
+ import scala.collection.JavaConverters._
Review comment:
How about moving this into the header and removing the other import?:
https://github.com/apache/spark/blob/fd899d6331f4777a36a3f2a79a6b2fa123dccc1a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala#L274
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
