Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4155#discussion_r23989226
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -808,6 +810,7 @@ class DAGScheduler(
         // will be posted, which should always come after a corresponding 
SparkListenerStageSubmitted
         // event.
         stage.latestInfo = StageInfo.fromStage(stage, 
Some(partitionsToCompute.size))
    +    outputCommitCoordinator.stageStart(stage.id)
    --- End diff --
    
    I think that this introduces a race between commit requests and the stage 
start event.  If the listener bus is slow in delivering events, then it's 
possible that the output commit coordinator could receive a commit request via 
Akka for a stage that it doesn't know about yet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to