zero323 commented on a change in pull request #20280:
[SPARK-22232][PYTHON][SQL] Fixed Row pickling to include __from_dict__ flag
URL: https://github.com/apache/spark/pull/20280#discussion_r338443486
##########
File path: python/pyspark/sql/types.py
##########
@@ -1445,15 +1447,15 @@ def __new__(self, *args, **kwargs):
raise ValueError("Can not use both args "
"and kwargs to create Row")
if kwargs:
- # create row objects
+ # create row object from named arguments, order not guaranteed so
will be sorted
names = sorted(kwargs.keys())
Review comment:
Thanks for pointing that out.
In my opinion dropping 3.5 support should be followed by removal of sorting
by name (from what I've seen this behavior is confusing at best and it will
have no use, once 3.5 support is dropped), although that might hard to sell,
especially in a minor version.
Ideally I would see `Row` going away completely, but that's just pie in the
sky.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
