HyukjinKwon commented on a change in pull request #20280:
[SPARK-22232][PYTHON][SQL] Fixed Row pickling to include __from_dict__ flag
URL: https://github.com/apache/spark/pull/20280#discussion_r338491481
##########
File path: python/pyspark/sql/types.py
##########
@@ -1445,15 +1447,15 @@ def __new__(self, *args, **kwargs):
raise ValueError("Can not use both args "
"and kwargs to create Row")
if kwargs:
- # create row objects
+ # create row object from named arguments, order not guaranteed so
will be sorted
names = sorted(kwargs.keys())
Review comment:
I think Spark 2.5 idea looks almost failed (and I either don't personally
support that idea). This thing is rather legitimate to make it happen between
minor releases. Actually, 3.0 is getting close. We could just let 3.0 release
first and remove that sorting behaviour too optionally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
