juliuszsompolski commented on a change in pull request #26221:
[WIP][SPARK-29108][SQL] Add new module sql/thriftserver and add v11 thrift
protocol
URL: https://github.com/apache/spark/pull/26221#discussion_r338517608
##########
File path: pom.xml
##########
@@ -240,6 +240,11 @@
<spark.test.home>${session.executionRootDirectory}</spark.test.home>
<CodeCacheSize>1g</CodeCacheSize>
+
+ <!-- Thrift properties -->
+ <thrift.home>you-must-set-this-to-run-thrift</thrift.home>
Review comment:
Does it need to be set, or can Maven find thrift from PATH? Or even better,
do the generation via libthrift from maven central itself?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
