huaxingao commented on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py URL: https://github.com/apache/spark/pull/26232#issuecomment-545952407 @zhengruifeng Sorry, I accidentally removed ```__metaclass__ = ABCMeta``` . Will add back. For the newly added setters in Transformers, most of them are new in 3.0.0. I will double check to make sure all the newly added one have ```@since("3.0.0")```. For the newly added setters in Estimators, all of them are existing ones. I initially tried to trace back the first version these setters appeared, and added a bunch of since annotations. Then I checked the documentation, and found out only the parameters that are specific to the Estimators/Transformers have since annotations in the setters, the parameters in HasXXX don't have since annotations in the setters. Here is one example for ```PCA```:  I guess I will only add ```@since("3.0.0")``` for the setters that are really new in 3.0.0. For the newly added setters in Estimators, since they are actually preexisting ones, I will not add since annotation. I guess I will remove the ones I have added. Does this sound good to you?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
