dongjoon-hyun commented on a change in pull request #26201:
[SPARK-29543][SS][UI] Init structured streaming ui
URL: https://github.com/apache/spark/pull/26201#discussion_r338758149
##########
File path: core/src/main/resources/org/apache/spark/ui/static/streaming-page.js
##########
@@ -300,6 +300,156 @@ function drawHistogram(id, values, minY, maxY, unitY,
batchInterval) {
}
}
+function drawAreaStack(id, labels, values, minX, maxX, minY, maxY) {
+ d3.select(d3.select(id).node().parentNode)
+ .style("padding", "8px 0 8px 8px")
+ .style("border-right", "0px solid white");
+
+ // Setup svg using Bostock's margin convention
+ var margin = {top: 20, right: 27, bottom: 30, left:
maxMarginLeftForTimeline};
+ var width = 850 - margin.left - margin.right;
+ var height = 300 - margin.top - margin.bottom;
+
+ var svg = d3.select(id)
+ .append("svg")
Review comment:
Maybe, `4 space` indent here to be consistent with the others?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
