Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4066#issuecomment-72617774
This patch looks like it's in pretty good shape. I did a bit of code
cleanup in OutputCommitCoordinator to reduce the visibility of some methods,
clarify when / where certain methods are invoked, and to more clearly explain
the API contract of `canCommit`. I also fixed a bug which I believe was
causing the CheckpointSuite failures that we observed on @mccheah's PR.
I've still got to take a closer look at the unit tests and maybe add a new
test to catch the bug that I fixed. I also have to manually test this on a
cluster to see if it fixes the reproduction of the original bug that prompted
this patch. I'll try to get to this tomorrow so this can make it into 1.3.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
