maropu commented on a change in pull request #26109: [SPARK-29461][SQL] Measure 
the number of records being updated for JDBC writer
URL: https://github.com/apache/spark/pull/26109#discussion_r338841138
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
 ##########
 @@ -672,6 +674,7 @@ object JdbcUtils extends Logging {
           }
           stmt.addBatch()
           rowCount += 1
 
 Review comment:
   Can you leave some comments somewhere about [the 
policy](https://github.com/apache/spark/pull/26109#discussion_r337864313) to 
collect metrics?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to