zero323 edited a comment on issue #20280: [SPARK-22232][PYTHON][SQL] Fixed Row 
pickling to include __from_dict__ flag
URL: https://github.com/apache/spark/pull/20280#issuecomment-546286996
 
 
   >  Besides dropping support for python versions, is it possible to remove 
the need for sorting fields by requiring an OrderedDict be used for versions 
before 3.6 or something similar?
   
   One could drop `**kwargs` completely ([standardish 
workaround](https://www.python.org/dev/peps/pep-0468/#motivation))
   
   ```python
   def __new__(self, *args):
       # "Keyword" path
       if args and len(args) == 1 and isinstance(args[0], OrderedDict):
           ...
       else:
            return tuple.__new__(self, args)
   ```
   
   but that's a breaking change with significant potential impact (updating 
docs alone would require a lot of work).
   
   In my opinion, not something that is justified only to support EOL Python 
versions, especially when 3.6 has been around for almost 3 years now, and 
migration doesn't require any changes in the user codebase.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to