shahidki31 commented on a change in pull request #26253: [SPARK-29599][WEBUI]
Support pagination for session table in JDBC/ODBC Tab
URL: https://github.com/apache/spark/pull/26253#discussion_r339068783
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
##########
@@ -377,6 +404,133 @@ private[ui] class SqlStatsPagedTable(
"%s/jobs/job/?id=%s".format(UIUtils.prependBaseUri(request,
parent.basePath), jobId)
}
+private[ui] class SessionStatsPagedTable(
+ request: HttpServletRequest,
+ parent: ThriftServerTab,
+ data: Seq[SessionInfo],
+ subPath: String,
+ basePath: String,
+ parameterOtherTable: Iterable[String],
+ sessionStatsTableTag: String,
+ pageSize: Int,
+ sortColumn: String,
+ desc: Boolean) extends PagedTable[SessionInfo] {
+
+ override val dataSource = new SessionStatsTableDataSource(data, pageSize,
sortColumn, desc)
+
+ private val parameterPath =
s"$basePath/$subPath/?${parameterOtherTable.mkString("&")}"
+
+ override def tableId: String = sessionStatsTableTag
+
+ override def tableCssClass: String =
+ "table table-bordered table-condensed table-striped " +
+ "table-head-clickable table-cell-width-limited"
+
+ override def pageLink(page: Int): String = {
+ val encodedSortColumn = URLEncoder.encode(sortColumn, UTF_8.name())
+ parameterPath +
+ s"&$pageNumberFormField=$page" +
+ s"&$sessionStatsTableTag.sort=$encodedSortColumn" +
+ s"&$sessionStatsTableTag.desc=$desc" +
+ s"&$pageSizeFormField=$pageSize"
+ }
+
+ override def pageSizeFormField: String = s"$sessionStatsTableTag.pageSize"
+
+ override def pageNumberFormField: String = s"$sessionStatsTableTag.page"
+
+ override def goButtonFormPath: String = {
+ val encodedSortColumn = URLEncoder.encode(sortColumn, UTF_8.name())
+
s"$parameterPath&$sessionStatsTableTag.sort=$encodedSortColumn&$sessionStatsTableTag.desc=$desc"
+ }
+
+ override def headers: Seq[Node] = {
+ val sessionTableHeaders =
+ Seq("User", "IP", "Session ID", "Start Time", "Finish Time", "Duration",
"Total Execute")
+
+ val tooltips = Seq[Option[String]](None, None, None, None, None, None,
None)
Review comment:
Do we need `tooltips` for the table?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
