squito commented on a change in pull request #24898: [SPARK-22340][PYTHON] Add
a mode to pin Python thread into JVM's
URL: https://github.com/apache/spark/pull/24898#discussion_r339092176
##########
File path: python/pyspark/context.py
##########
@@ -1010,13 +1010,42 @@ def setJobGroup(self, groupId, description,
interruptOnCancel=False):
ensure that the tasks are actually stopped in a timely manner, but is
off by default due
to HDFS-1208, where HDFS may respond to Thread.interrupt() by marking
nodes as dead.
"""
+ warnings.warn(
Review comment:
ok, I see your point. I don't feel great about any of our options here, but
perhaps you are right. I do wish there was a way we could warn more loudly
when using this in non-pinned mode.
I'm just brainstorming here -- another thing we could do is just have the
spark UI display some big warning for all of these fields whenever you're using
pyspark in non-pinned mode (if we can reliabaly detect this). Eg. job group
would just say "Unavailable with pyspark in non-pinned mode -- see docs (link)".
(Even if we want to do that, doesn't need to be done here.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
