MaxGekk commented on a change in pull request #26177: [SPARK-29520][SS] Fix
checks of negative intervals
URL: https://github.com/apache/spark/pull/26177#discussion_r339126390
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -119,4 +121,32 @@ object IntervalUtils {
case _: IllegalArgumentException => null
}
}
+
+ /**
+ * Gets interval duration
+ *
+ * @param cal - the interval to get duration
+ * @param targetUnit - time units of the result
+ * @param daysPerMonth - the number of days per one month
+ * @return duration in the specified time units
+ */
+ def getDuration(
+ cal: CalendarInterval,
+ targetUnit: TimeUnit,
+ daysPerMonth: Int = 31): Long = {
Review comment:
What do you propose is ad-hoc interface which solves current issue only. I
don't like it because it makes interval interface not reusable.
- Next time when we need durations in another place, are you going to add
`getDurationForAnotherPlace1`?
- If someone will need a duration with 31 days per month for different
purpose but not for watermarks, he/she cannot use it even in Structured
Streaming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
